-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS examples: tabbing through the examples doesn't move the blue border+arrow #349
Comments
I reviewed this issue and notice that bug have another causal relationship. Switching between examples via tab button occurs because of an improperly setuped event listener: exampleChoiceList.addEventListener('keyup', function(event) {
var exampleChoiceParent = event.target.parentElement;
cssEditorUtils.applyCode(
exampleChoiceParent.textContent,
exampleChoiceParent
);
if (!localStorage.getItem('firstCSSEditRecorded')) {
mceAnalytics.trackFirstEdit('css');
}
}) The handler is called after each keystroke of any key (with focus on the list of examples) and applies the current code snippet. The problem is that this handler is also called when |
@diablero13 That sounds like a great analysis. You want to grab this one? |
Yes. Actually I already fixed it. I'll make PR soon. |
Awesome, thanks so mcuh |
Moved to mdn/bob#548 |
If I've selected an example in the CSS editor and tab, I should move to the next example. I do (in that the next example is applied), but the blue border and arrow that's used to indicate the current example isn't updated.
The text was updated successfully, but these errors were encountered: