"logger" instead of "console"

[wbamberg]

Looking at https://developer.mozilla.org/en-US/docs/User:schalkneethling:push

The code sample has "logger.log()" not "console.log()". Is there a reason for this? I'd have thought console would be more obvious.

[schalkneethling]

The code sample has "logger.log()" not "console.log()". Is there a reason for this? I'd have thought console would be more obvious.

I changed it to logger. The reason is that should you try to actually .log, .dir or anything like that when debugging the live editor code, this override swallows it :-/

[wbamberg]

Yes, that makes sense. I don't know if you changed the implementation of console, but in the original it was pretty basic!

[wbamberg]

I'd like to reopen this. Feedback in our testing in SF was that "logger" was confusing. I think at least we should reconsider whether to use "console".

[schalkneethling]

@wbamberg Actually, the way I refactored the code, would allow us to do that now. The problem previously was that the variables and function were all exposed to the global object and so, our console was overriding the global console. I will make this change.

[schalkneethling]

No, I take that back. For it to work with the examples it needs to be exposed to the global object which means we will be overwriting the global console :-/

[schalkneethling]

Ok, never mind again ;) Turns out there is a way to have the best of both.

[schalkneethling]

Resolved in #97