-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"logger" instead of "console" #77
Comments
I changed it to |
Yes, that makes sense. I don't know if you changed the implementation of |
I'd like to reopen this. Feedback in our testing in SF was that "logger" was confusing. I think at least we should reconsider whether to use "console". |
@wbamberg Actually, the way I refactored the code, would allow us to do that now. The problem previously was that the variables and function were all exposed to the global object and so, our |
No, I take that back. For it to work with the examples it needs to be exposed to the global object which means we will be overwriting the global console :-/ |
Ok, never mind again ;) Turns out there is a way to have the best of both. |
Resolved in #97 |
Looking at https://developer.mozilla.org/en-US/docs/User:schalkneethling:push
The code sample has "logger.log()" not "console.log()". Is there a reason for this? I'd have thought console would be more obvious.
The text was updated successfully, but these errors were encountered: