Adding an example for the String.substring() method #1074
Conversation
| console.log(str.substring(2,str.length)); 'zilla' | ||
| </code> | ||
| </pre> | ||
|
|
There was a problem hiding this comment.
Please remove this line containing just spaces, ad all files should end with a return character (that's what the
is telling you).
| <pre> | ||
| <code id="static-js">const str = 'Mozilla'; | ||
| console.log(str.substring(1,2)); // 'oz' | ||
| console.log(str.substring(2,str.length)); 'zilla' |
There was a problem hiding this comment.
There's no point doing this: str.substring(2,str.length), because it's just the same as str.substring(2).
In fact let's use str.substring(2) instead on this line, then we can illustrate the optional parameter.
| console.log(str.substring(2)); | ||
| // expected output "zilla" | ||
| </code> | ||
| </pre> |
There was a problem hiding this comment.
This line still seems to end without a newline.
There was a problem hiding this comment.
There should be one now.
| <code id="static-js">var str = 'Mozilla'; | ||
|
|
||
| console.log(str.substring(1, 2)); | ||
| // expected output "oz" |
There was a problem hiding this comment.
This actually returns "o" not "oz". Sorry, should have caught this last time round.
Also, sorry to be super-nitpicky, but the format is:
// expected output: thing
Note the colon. Sorry to be so nitpicky, but it's worth being exact about this I think.
There was a problem hiding this comment.
I should have caught "oz" too. I fixed the code so it produces the intended result and also fixed the comments.
| <code id="static-js">var str = 'Mozilla'; | ||
|
|
||
| console.log(str.substring(1, 2)); | ||
| // expected output: "oz" |
There was a problem hiding this comment.
This still seems to be wrong. It should be either (1, 3) or expected output: "o"
There was a problem hiding this comment.
I would have sworn that I made this change already but I've fixed it and pushed again.
* upstream/master: Add window.ieConfig.origin for the target origin (mdn#1112) Improve example code (mdn#1111) Adding an example for the String.substring() method (mdn#1074) Adding an example for String.slice() (mdn#1081) Adding an example of String.split() (mdn#1071) Adding an example for the String.substr() method (mdn#1073) chore(deps): update dependency jest to v23.5.0 (mdn#1109) chore(deps): update dependency puppeteer to v1.7.0 (mdn#1108) Estelle/morestrings (mdn#1095) Added method for String[@@iterator]() (mdn#1069) Replace header image with a CC0 one (mdn#1100) chore(deps): update dependency prettier to v1.14.2 (mdn#1107) chore(deps): update dependency clean-css to v4.2.1 (mdn#1096) Update main element example to use cc0 image (mdn#1092) Update cc0 figcaption (mdn#1091) Fix meta.json for contenteditabl (mdn#1106)
No description provided.