Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window.ieConfig.origin for the target origin #1112

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

jwhitlock
Copy link
Contributor

Add a global configuration ieConfig, with a single member origin for the target origin for postMessage calls. Allow overriding the origin with ?origin=https://example.com.

Fixes #257.

Add a global configuration ieConfig, with a single member origin for the
target origin for postMessage calls. Allow overriding the origin with
?origin=https://example.com.

Fixes mdn#257.
Copy link
Contributor

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks @jwhitlock r+

@schalkneethling schalkneethling self-assigned this Aug 17, 2018
@schalkneethling schalkneethling added the enhancement Improves an existing feature. label Aug 17, 2018
@schalkneethling schalkneethling added this to the Sprint 3 Q3 2018 milestone Aug 17, 2018
@schalkneethling schalkneethling merged commit bd8a91b into mdn:master Aug 17, 2018
wbamberg pushed a commit to wbamberg/interactive-examples that referenced this pull request Aug 31, 2018
* upstream/master:
  Add window.ieConfig.origin for the target origin (mdn#1112)
  Improve example code (mdn#1111)
  Adding an example for the String.substring() method (mdn#1074)
  Adding an example for String.slice() (mdn#1081)
  Adding an example of String.split() (mdn#1071)
  Adding an example for the String.substr() method (mdn#1073)
  chore(deps): update dependency jest to v23.5.0 (mdn#1109)
  chore(deps): update dependency puppeteer to v1.7.0 (mdn#1108)
  Estelle/morestrings (mdn#1095)
  Added method for String[@@iterator]() (mdn#1069)
  Replace header image with a CC0 one (mdn#1100)
  chore(deps): update dependency prettier to v1.14.2 (mdn#1107)
  chore(deps): update dependency clean-css to v4.2.1 (mdn#1096)
  Update main element example to use cc0 image (mdn#1092)
  Update cc0 figcaption (mdn#1091)
  Fix meta.json for contenteditabl (mdn#1106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants