Update cc0 figcaption #1091
Merged
Update cc0 figcaption #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 3, 2018 09:39
Replaced the hamster with an elephant at sunset. Updated the CSS to work with the new image, and replaced the figure's caption text.
schalkneethling
suggested changes
Aug 7, 2018
There was a problem hiding this comment.
One minor change required, other than that, this looks great! Thanks @a2sheppy
| @@ -4,10 +4,10 @@ figure { | |||
| flex-flow: column; | |||
| margin: 0; | |||
| padding: 5px; | |||
| width: 22em; | |||
There was a problem hiding this comment.
I would suggest making this width: 19em; as 22 causes the output area to scroll vertically.
|
While it doesn't require scrolling for me, it's close, so I presume it's due to local font configuration differences. I will submit an update momentarily. |
where font sizes are just a little bigger than for me.
wbamberg
pushed a commit
to wbamberg/interactive-examples
that referenced
this pull request
Aug 31, 2018
* upstream/master: Add window.ieConfig.origin for the target origin (mdn#1112) Improve example code (mdn#1111) Adding an example for the String.substring() method (mdn#1074) Adding an example for String.slice() (mdn#1081) Adding an example of String.split() (mdn#1071) Adding an example for the String.substr() method (mdn#1073) chore(deps): update dependency jest to v23.5.0 (mdn#1109) chore(deps): update dependency puppeteer to v1.7.0 (mdn#1108) Estelle/morestrings (mdn#1095) Added method for String[@@iterator]() (mdn#1069) Replace header image with a CC0 one (mdn#1100) chore(deps): update dependency prettier to v1.14.2 (mdn#1107) chore(deps): update dependency clean-css to v4.2.1 (mdn#1096) Update main element example to use cc0 image (mdn#1092) Update cc0 figcaption (mdn#1091) Fix meta.json for contenteditabl (mdn#1106)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the hamster image (which was free but not expressly labeled cc0) with a silhouetted elephant. Wrote a new caption, and updated the CSS to work with the shape of the image better.