Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Translate {{HTTPSidebar}} to Korean #1124

Merged
merged 2 commits into from
May 15, 2019
Merged

Translate {{HTTPSidebar}} to Korean #1124

merged 2 commits into from
May 15, 2019

Conversation

cs09g
Copy link
Contributor

@cs09g cs09g commented Apr 18, 2019

No description provided.

@cs09g
fix wrong key name
9dbe3ed 
key name's not changed
@ExE-Boss
Copy link
Contributor

The pull request name should be:
feat: Translate {{HTTPSidebar}} to Korean

@cs09g
Copy link
Contributor Author

cs09g commented Apr 22, 2019

@ExE-Boss Where can I find the rule for commit or PR name? so I could follow.

@ExE-Boss
Copy link
Contributor

ExE-Boss commented Apr 22, 2019 •
edited
Loading

I tend to use a modified angular.js commit format (I capitalise the subject)

As for the subject itself, that should be a descriptive summary. For this, that would be: “Translate {{HTTPSidebar}} to Korean”.

@cs09g cs09g changed the title add macro for ko Translate {{HTTPSidebar}} to Korean Apr 29, 2019
wbamberg
wbamberg approved these changes May 15, 2019
View reviewed changes
Copy link

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @cs09g , and sorry to take so long to review it.

I can't vouch for the translations but I trust that they are good :). Formally this looks fine and I've tested in a local Kuma and it behaves as expected.

@wbamberg wbamberg merged commit a98bd76 into mdn:master May 15, 2019
wbamberg pushed a commit to wbamberg/kumascript that referenced this pull request May 15, 2019
Merge remote-tracking branch 'upstream/master' into add-httpsidebar-test
5f97fef 
* upstream/master:
  Translate {{HTTPSidebar}} to Korean (mdn#1124)
  Fix typo in URL for Using the Screen Capture API in sidebar (mdn#1148)
  adding JavaScript modules article to JS Sidebar (mdn#1151)
@wbamberg
Copy link

Also, @cs09g :

@ExE-Boss Where can I find the rule for commit or PR name? so I could follow.

The KumaScript repository doesn't have a policy for commit messages or PR names, so don't worry about this. It is a good idea for names to be clear of course, but there are no specific rules to follow here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@davidflanagan davidflanagan Awaiting requested review from davidflanagan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cs09g @ExE-Boss @wbamberg