-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to an archived page shows up as broken link/flaw #2675
Comments
Only just last did we add a think so we now know what all the archived URLs are. We'll use that in the |
@hamishwillee Do you know, by heart, a good page to test this with? |
CC @fiji-flo
Basically, we don't have, in
Rows like this got send to |
However, there is some hope. On http://localhost:3000/en-US/docs/Mozilla/Firefox#_flaws for example, there's a <a href="/en-US/docs/Mozilla/Firefox/Multiple_profiles">use multiple Firefox profiles</a> which shows up as "broken" and not being fixable. However, in the
equipped with that, you can conclude it's not a broken link. It's just archived. So it shouldn't be flagged as a flaw. |
Excellent, and even though I don't know a good test page, you can find one easily in archived.txt :-) |
* link to archived pages is not a broken link Part of #2675 * refactor
Note-to-self; #2687 make things better. |
@peterbe Should #2687 be working now? I just pulled upstream main, did yarn install, and tried this - still see the flaw on your test page: http://localhost:5000/en-US/docs/Mozilla/Firefox#_flaws Don't want to seem ungrateful because this is MUCH better for me - having a false-positive flaw I can't do anything about is annoying and unhelpful. Upshot, if it is actually a flaw to link to an archived document then we should leave the link in, but add highlighting and an explanation of why it is a flaw. If it is not a flaw to link to an archived document, then please ignore this and accept my thanks. |
Just seconds off the presses, mdn/content#1889 upgrades the Yari that's shipped inside mdn/content. Secondly, the flaw system isn't yet smart enough to make "policy decisions" about links to sections that we don't care for. As a note, archiving is hard. The reason we're doing it is to remove things that make the content repo otherwise unnecessarily heavy. By shoving it away from our active repo, we're also saving electricity waste by not building it frequently. |
@peterbe I'm still getting the test case shown in flaws ("Multiple profiles" doc). I've updated to latest and run So either this did not fix the problem, it did not get pulled in, or is being affected by some of my other problems. Yes, archiving is hard. It's a lot easier though if you apply a "reason" for the archiving at the point you make the change. That might be a good case for page metadata. |
@peterbe So I see 3 flaws - including multiple profiles. BUT they are all valid - including the multiple profiles link, which now opens (and even though this is still listed in archive.txt (en-us/mozilla/firefox/multiple_profiles/index.html). So a) I don't know why you see different, b) is there a known archive link I can test that is present in docs. I tried a few from archive.txt but can't find any hits. |
Actually test case might be http://localhost:5000/en-US/docs/Web/JavaScript/#_flaws The flaw shown is in the archived.txt and if you click it there is a redirect. |
@peterbe FYI This is still a problem (archived pages showing up as broken links). It is a bit of a pain frankly, because I have to check them manually. |
The only way I think of solving this is if you have a checkout of the github.com/mdn/archived-content on your laptop and then you add Do you think that's a viable thing? Most people wouldn't need to worry about it but serious editors and writers like yourself can perhaps go the extra mile to get that figured out. |
@peterbe That absolutely works "for me". If you were feeling very brave you could even add a yarn option to fetch the archive and update the env for those who want it. Just an idea. Given that the archived links are more or less static might we not be better off just generating a static list of the archived topics and use that to hide the flaw (and possibly provide a stub target "archived topic"). |
Quite complicatedly, we have a list of all the files |
I guess then it comes down to the effort of perhaps importing that list of redirects (and using it) or your proposal. Either is much better "for power users" than the current situation. |
@hamishwillee Is this still an issue? I think I'm missing context to understand what a link to an archived page is, because I only know about the archived-content repo. |
@caugner Closing. TLDR; FYI the historical context was that in the past the archived content was held in a separate repo, but built with yari using special setup that put clear "archiving" borders around it. When I posted this you got a warning when doing local testing, even though the content would actually be build on release - i.e a false positive. We no longer build the archived material so this is invalid - a broken link is a real flaw :-). |
Locally testing I see broken links reported as a non-fixable flaw. Sometimes this is because the link is to an archived page (it appears archived pages are not fetched when you get the source).
Not sure what the solution is - perhaps a hint that this is possible, and in this case what we expect people to do in that case?
The text was updated successfully, but these errors were encountered: