-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Our favicon.ico is 15KB! #3611
Comments
In the last month, according to https://console.aws.amazon.com/cloudfront/home?region=us-west-2#popular_urls: If the file was 789 bytes instead, we'd only be sending ~18GB from the CDN servers to people's browsers. On top of that, at a 1 day TTL it also means that each CDN server will only cache it on their end for 1 day. That means it will more frequently wake up S3 to look it up and have it transferred from S3 to the CDN. This is also part of the electricity waste. |
#3621 takes care of "forcing" people to download |
#3620 takes care of making the default But there's still something I don't understand. Look at our index.html and you'll see something like this: <link
rel="shortcut icon"
href="/favicon.323ad90c.ico"
type="image/x-icon"
/>
<link
rel="apple-touch-icon-precomposed"
sizes="144x144"
href="/favicon144.e7e21ca2.png"
/>
<link
rel="apple-touch-icon-precomposed"
sizes="114x114"
href="/favicon114.d526f38b.png"
/>
<link
rel="apple-touch-icon-precomposed"
sizes="72x72"
href="/favicon72.cc65d1d7.png"
/>
<link rel="apple-touch-icon-precomposed" href="/favicon57.de331799.png" /> (the hashing of filenames isn't important right now) But why does my Firefox download both the It appears to only happen in Firefox (Nightly?) and not in Chrome where most traffic comes from. But I don't know the origin of the I wonder if we can just delete them all and just use 1 image (white dino head on black background) called |
Curious thing. When I run Chrome from Webpagetest.org I see that it downloads the |
* optimize how we set the shortcut icon Part of #3611 * fix eslint problem * fix scripts * use logger.info instead * add favicon-48x48.png for the new default favicon * add a test
* do away with the favicon144.png image Part of #3611 * all of 'em * optimize the image with Optimage * rename, add 192x192, and rearrange tests * optimized the favicon-32x32.png too * feedbacked * fix tests
* optimize how we set the shortcut icon Part of mdn#3611 * fix eslint problem * fix scripts * use logger.info instead * add favicon-48x48.png for the new default favicon * add a test
* do away with the favicon144.png image Part of mdn#3611 * all of 'em * optimize the image with Optimage * rename, add 192x192, and rearrange tests * optimized the favicon-32x32.png too * feedbacked * fix tests
@peterbe given that #3620 #3621 and #3622 are all merged to main, I guess it can be closed? I'm kinda curious if those changes has made a (positive) impact to MDN, in particular:
|
From ~348GB to ~316MB. So 1000x is a good amount of saved electricity. I would call that a win! |
@peterbe WOW. That's way more than I imagined. Thanks! |
The file
favicon-32x32.png
is 789 bytes. The favicon.ico is 15086 bytes. Yikes!The text was updated successfully, but these errors were encountered: