-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexsearch with popularity basic #234
Conversation
return { | ||
title: this._map[uri].title, | ||
uri, | ||
popularity: this._map[uri].popularity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not be needed/used but I think I put it in there when I was debugging the popularity in the results display.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only read it, didn't run it (as I didn't have time yet to look into why Milton wasn't working for me). But code looks good though.
391ff6d
to
efbd16c
Compare
@Gregoor I took your minor nits and I also converted from fat arrow functions to regular functions in the |
Fixes #49
Fixes #231