Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsxref shouldn't localize slugs #3132

Merged
merged 2 commits into from
Mar 4, 2021
Merged

jsxref shouldn't localize slugs #3132

merged 2 commits into from
Mar 4, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Mar 4, 2021

There's no point anymore in trying to localize the slugs since there are no more localized slugs.

@peterbe
Copy link
Contributor Author

peterbe commented Mar 4, 2021

@fiji-flo I appreciate that the jsxref macro is a dying thing but it might be a while till we clean up that macro everywhere. Especially for the translated content.

@peterbe peterbe requested a review from fiji-flo March 4, 2021 15:59
@peterbe
Copy link
Contributor Author

peterbe commented Mar 4, 2021

@escattone CC'd
I'm going to see if there are other xref macros that do similar things.

fiji-flo
fiji-flo approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@fiji-flo fiji-flo merged commit b23b659 into mdn:main Mar 4, 2021
@peterbe peterbe deleted the jsxref-shouldnt-localize-slugs branch March 4, 2021 17:08
peterbe added a commit to peterbe/yari that referenced this pull request Jun 1, 2021
@peterbe
jsxref shouldn't localize slugs (mdn#3132)
59f6a49 
* jsxref shouldn't localize slugs

* delete refs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiji-flo fiji-flo fiji-flo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterbe @fiji-flo