-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(testing/tests): convert to typescript #6487
Conversation
b619a0c
to
4fd6e42
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
78d53b6
to
e1201f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small comment, otherwise looks good!
testing/tests/index.test.ts
Outdated
// @ts-ignore | ||
const { hyData: { recentContributions } = {} } = JSON.parse( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think this ts-ignore
is necessary if you do:
const { hyData: { recentContributions = {} } = {} } = JSON.parse(
Otherwise it returns a Buffer.
Summary
Converts
/testing/tests
to TypeScript.How did you test this change?
scripts/testing.sh
andscripts/developing.sh
locally.