Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(testing/tests): convert to typescript #6487

Merged
merged 6 commits into from
Jun 20, 2022

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jun 7, 2022

Summary

Converts /testing/tests to TypeScript.

⚠️ Includes two cherry-picks from #6489, so preferably merge that PR first.


How did you test this change?

  • Ran scripts/testing.sh and scripts/developing.sh locally.
  • Checks are 🟢.

@caugner caugner force-pushed the typescript-tests branch 2 times, most recently from b619a0c to 4fd6e42 Compare June 7, 2022 13:35
@caugner caugner marked this pull request as ready for review June 7, 2022 13:36
@caugner caugner requested a review from LeoMcA June 7, 2022 13:40
@caugner caugner marked this pull request as draft June 7, 2022 14:11
@github-actions github-actions bot added dependencies Pull requests that update a dependency file merge conflicts 🚧 Please rebase onto or merge the latest main. labels Jun 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@caugner caugner removed the request for review from LeoMcA June 7, 2022 14:26
@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Jun 7, 2022
@github-actions github-actions bot added the markdown markdown related issues and pull requests label Jun 7, 2022
@caugner caugner force-pushed the typescript-tests branch 3 times, most recently from 78d53b6 to e1201f3 Compare June 7, 2022 16:00
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jun 7, 2022
@github-actions github-actions bot removed the markdown markdown related issues and pull requests label Jun 7, 2022
@github-actions github-actions bot added the markdown markdown related issues and pull requests label Jun 7, 2022
@caugner caugner marked this pull request as ready for review June 7, 2022 17:19
@caugner caugner requested a review from LeoMcA June 7, 2022 17:20
@github-actions github-actions bot removed the markdown markdown related issues and pull requests label Jun 9, 2022
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small comment, otherwise looks good!

Comment on lines 1526 to 1527
// @ts-ignore
const { hyData: { recentContributions } = {} } = JSON.parse(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this ts-ignore is necessary if you do:
const { hyData: { recentContributions = {} } = {} } = JSON.parse(

@LeoMcA LeoMcA merged commit 4d53f87 into mdn:main Jun 20, 2022
@caugner caugner deleted the typescript-tests branch July 1, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants