Allow alternate nightly spec URLs #7262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: the failing test is unrelated to this PR and can be dismissed. |
schalkneethling
added
the
p1
sideshowbarker
approved these changes
Oct 13, 2022
|
Is there any strong reason that we shouldn’t go ahead and merge this PR? Especially is there any strong reason to further delay on it relative to the harm the problem is continuing to cause for MDN readers who’ve been seeing “Unknown specification” for all CSS specs for an entire month now? The change in this PR can’t make anything worse than the current “Unknown specification” situation. And it’s not a change that requires a huge amount of scrutiny; the solution here seems pretty straightforward — and it’s hard to imagine there being any way to improve upon what’s already in the patch in this PR. |
This was referenced Oct 13, 2022
schalkneethling
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the last few releases, a pull request was merged to BCD that replaces links to
drafts.csswg.orgwithw3c.github.io/csswg-drafts. This was done becausedrafts.csswg.orgis almost always unavailable, leaving MDN readers (including and especially contributors) with no spec to refer to. The downtime issues have persisted for over a year, with no end in sight. Because of this, various developers have created their own mirrors with reliable build engines, including https://andreubotella.com/csswg-auto-build/, whose code was then used to create a new official mirror.As an unfortunate result, however, any spec URLs using the new mirror will show "Unknown specification". This has been resolved in
browser-specsby adding a newalternateUrlsproperty that contains the URL to the mirror. This PR taps into this new property, resolving the "unknown specification" issue.This fixes #7173 and fixes mdn/content#20772. This closes #7175 as irrelevant.