fix(macros): escape page.title in sidebars #8371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
added
p0
wbamberg
approved these changes
Mar 7, 2023
No worries. :) |
This was referenced Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8369, fixes #8370.
Problem
Page titles used as link text were not properly escaped, so page titles containing HTML elements (such as
<object> 로부터 <iframe>까지 — 기타 임베딩 기술) broke the sidebar.Solution
Use
htmlEscapeto escape thepage.title.Screenshots
Before
After
How did you test this change?
Ran
yarn devand opened http://localhost:3000/ko/docs/Learn/Getting_started_with_the_web locally.