Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup-python in GitHub Actions #57

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

eytanadler
Copy link
Contributor

Purpose

In #56, I believe setup-python@v2 was accidentally changed to checkout@v4 rather than setup-python@v4. This PR fixes that.

Expected time until merged

Soon, since this affects the builds of all repos that use GitHub Actions (the flake8 action is probably the most pressing).

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eytanadler eytanadler requested a review from a team as a code owner June 19, 2023 17:36
@eytanadler eytanadler requested review from A-CGray, marcomangano and eirikurj and removed request for a team and A-CGray June 19, 2023 17:36
@eirikurj eirikurj merged commit 23124c0 into mdolab:main Jun 19, 2023
@eytanadler eytanadler deleted the fix_setup_python branch June 19, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants