Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complex kwarg #173

Merged
merged 3 commits into from
Nov 15, 2021
Merged

Fix complex kwarg #173

merged 3 commits into from
Nov 15, 2021

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Nov 15, 2021

Purpose

The complex keyword argument has been renamed to isComplex in pyGeo. This PR makes the corresponding updates here. I also renamed a few other things to make the code more readable.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Existing tests should run and no longer raise a warning.

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner November 15, 2021 16:23
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #173 (c6fbb82) into master (f999afc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   42.74%   42.74%           
=======================================
  Files          15       15           
  Lines        3495     3495           
=======================================
  Hits         1494     1494           
  Misses       2001     2001           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f999afc...c6fbb82. Read the comment docs.

@marcomangano marcomangano merged commit 08f431a into master Nov 15, 2021
@marcomangano marcomangano deleted the fix-complex-kwarg branch November 15, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants