Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #179

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Fixed typo #179

merged 2 commits into from
Jan 27, 2022

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Jan 27, 2022

Purpose

Um, I think all the lift files written in the last however many years have all had this typo... how did this never come up before?

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner January 27, 2022 02:44
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #179 (15152b2) into master (f870d03) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   42.99%   42.99%           
=======================================
  Files          15       15           
  Lines        3503     3503           
=======================================
  Hits         1506     1506           
  Misses       1997     1997           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f870d03...15152b2. Read the comment docs.

@sseraj
Copy link
Collaborator

sseraj commented Jan 27, 2022

how did this never come up before?

People probably saw it, but never bothered to fix it...
Speaking of which, can I tack on another one-character typo fix in this PR? This one shows up every time you run ADflow.

Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anilyil anilyil self-requested a review January 27, 2022 08:57
@anilyil anilyil merged commit b98c553 into master Jan 27, 2022
@anilyil anilyil deleted the fix-typo branch January 27, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants