-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed printing to use proper scientific notation #180
Conversation
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 43.10% 43.10%
=======================================
Files 15 15
Lines 3517 3517
=======================================
Hits 1516 1516
Misses 2001 2001 Continue to review full report at Codecov.
|
@nwu63 I updated one more place that I was aware was missing. Think this is somewhat complete in terms of printout to the terminal. |
I agree, I've pushed up some more changes. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this out locally and it is a definite improvement. I actually like 16 digits being printed for the monitor variables, so I am fine with this as is. I also checked that the Tecplot output files still work with the new format.
Purpose
I changed a lot of the printing that used the format
e.
to usees.
, so that numbers show up as4.9E2
instead of0.49E3
. I was really annoyed with the constant leading zero, so this should make everything more readable.I used some regex to find these, so I might've missed some stuff. Would appreciate some checking by ADflow maintainers since I'm not as familiar with the code. This may also be a good time to change other printing formats, especially since I noticed we are now showing 16 decimal places which is probably too much.
Type of change
Testing
I ran the MACH-Aero tutorial and saw that the printing is now using proper scientific notation.
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted