-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kwargs for addPointSet #192
Conversation
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
=======================================
Coverage 43.62% 43.62%
=======================================
Files 15 15
Lines 3519 3519
=======================================
Hits 1535 1535
Misses 1984 1984
Continue to review full report at Codecov.
|
After some discussion, we have decided to move the kwargs to the setDVGeo function. This function is in AeroSolver in baseclasses, so mdolab/baseclasses#73 will have to be merged before this PR. |
The tests will fail until mdolab/baseclasses#73 is merged and available on Docker. |
The tests are passing now so this is ready to review @anilyil @marcomangano |
Purpose
I added an optional input to the
ADFLOW
class which passes keyword arguments toDVGeo.addPointSet()
. This is useful for DVGeometryMulti (mdolab/pygeo#113), specifying projection tolerances (mdolab/pygeo#116), and any otheraddPointSet
kwargs from any DVGeo type.Type of change
Testing
I tested locally with my DVGeometryMulti case.
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted