Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kwargs for addPointSet #192

Merged
merged 2 commits into from
Feb 18, 2022
Merged

kwargs for addPointSet #192

merged 2 commits into from
Feb 18, 2022

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Feb 15, 2022

Purpose

I added an optional input to the ADFLOW class which passes keyword arguments to DVGeo.addPointSet(). This is useful for DVGeometryMulti (mdolab/pygeo#113), specifying projection tolerances (mdolab/pygeo#116), and any other addPointSet kwargs from any DVGeo type.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

I tested locally with my DVGeometryMulti case.

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner February 15, 2022 20:14
marcomangano
marcomangano previously approved these changes Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #192 (b7a8cc1) into master (007c8a8) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b7a8cc1 differs from pull request most recent head 47d0805. Consider uploading reports for the commit 47d0805 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   43.62%   43.62%           
=======================================
  Files          15       15           
  Lines        3519     3519           
=======================================
  Hits         1535     1535           
  Misses       1984     1984           
Impacted Files Coverage Δ
adflow/pyADflow.py 68.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007c8a8...47d0805. Read the comment docs.

@sseraj sseraj marked this pull request as draft February 15, 2022 21:20
@sseraj
Copy link
Collaborator Author

sseraj commented Feb 15, 2022

After some discussion, we have decided to move the kwargs to the setDVGeo function. This function is in AeroSolver in baseclasses, so mdolab/baseclasses#73 will have to be merged before this PR.

@sseraj sseraj marked this pull request as ready for review February 15, 2022 21:45
@sseraj
Copy link
Collaborator Author

sseraj commented Feb 15, 2022

The tests will fail until mdolab/baseclasses#73 is merged and available on Docker.

@sseraj
Copy link
Collaborator Author

sseraj commented Feb 18, 2022

The tests are passing now so this is ready to review @anilyil @marcomangano

@marcomangano marcomangano merged commit 3a6e8e8 into master Feb 18, 2022
@marcomangano marcomangano deleted the pointSetKwargs branch February 18, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants