Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed beta derivative conversion #209

Merged
merged 5 commits into from
Mar 25, 2022
Merged

Fixed beta derivative conversion #209

merged 5 commits into from
Mar 25, 2022

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Mar 25, 2022

Purpose

As mentioned in #208, the beta derivatives need to be converted from 1/radians to 1/degrees in the same way as the alpha derivatives.

I also updated the beta derivative reference values in the adjoint tests. I trained the tests on the u20-gcc-ompi-latest image.

Expected time until merged

Ideally by the end of the day

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner March 25, 2022 15:26
@sseraj
Copy link
Collaborator Author

sseraj commented Mar 25, 2022

Actually, I also need to retrain the functionals tests

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #209 (2bd961c) into main (196caaa) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   43.33%   43.32%   -0.02%     
==========================================
  Files          15       15              
  Lines        3551     3550       -1     
==========================================
- Hits         1539     1538       -1     
  Misses       2012     2012              
Impacted Files Coverage Δ
adflow/pyADflow.py 67.45% <100.00%> (-0.02%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

marcomangano
marcomangano previously approved these changes Mar 25, 2022
anilyil
anilyil previously approved these changes Mar 25, 2022
@sseraj sseraj dismissed stale reviews from anilyil and marcomangano via 2bd961c March 25, 2022 22:44
@anilyil anilyil self-requested a review March 25, 2022 23:40
@anilyil anilyil merged commit 0a9fe1b into main Mar 25, 2022
@anilyil anilyil deleted the beta-deriv branch March 25, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants