added rootSetOption and error estimation #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 40.78% 41.04% +0.26%
==========================================
Files 13 13
Lines 3769 3793 +24
==========================================
+ Hits 1537 1557 +20
- Misses 2232 2236 +4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
adflow/pyADflow.py
Outdated
| @@ -4682,7 +4682,7 @@ def solveErrorEstimate(self, aeroProblem, funcError, evalFuncs=None): | |||
| -------- | |||
| >>> funcs = {} | |||
| >>> CFDsolver(ap) | |||
| >>> CFDsolver.solveErrorEstimate(ap1, funcError, ['cl', 'cd']) | |||
| >>> CFDsolver.solveErrorEstimate(ap, funcError, ['cl', 'cd']) | |||
| >>> funcs | |||
| >>> # Result will look like (if aeroProblem, ap1, has name of 'wing'): | |||
sseraj
reviewed
May 22, 2022
adflow/pyADflow.py
Outdated
| Parameters | ||
| ---------- | ||
| aeroProblem : pyAero_problem class | ||
| The aerodynamic problem to to get the error for |
sseraj
approved these changes
May 22, 2022
marcomangano
approved these changes
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds two things:
Expected time until merged
Soon.
Type of change
Testing
There are two tests.
Checklist
flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted