Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick bug fix in getSolution #226

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Quick bug fix in getSolution #226

merged 1 commit into from
Jul 7, 2022

Conversation

joanibal
Copy link
Collaborator

@joanibal joanibal commented Jul 6, 2022

Purpose

When you call getSolution with multiple families the values calculated by the earlier families are zeroed on the last iteration.
I don't believe this was ever the intended behavior and frankly I'm surprised this was left on unfixed for so long.
When using evalFunctions 'getSolution` is called individually for each group which is why this isn't currently messing up everyone's cases

Expected time until merged

1 week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Ask @lambe for his test script if you'd like

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

When you call getSolution with multiple families the values calculated by the earlier families are zeroed on the iteration. 
I don't believe this was ever the intended behavior and frankly I'm surprised this was left on unfixed for so long.
@joanibal joanibal requested a review from a team as a code owner July 6, 2022 22:35
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #226 (20d2ac1) into main (ea3e48d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   41.04%   41.04%           
=======================================
  Files          13       13           
  Lines        3793     3793           
=======================================
  Hits         1557     1557           
  Misses       2236     2236           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Ideally we should have a test to cover this, but I assume this is not going to happen in the short term.

@marcomangano marcomangano merged commit ea9b0ed into main Jul 7, 2022
@marcomangano marcomangano deleted the joanibal-patch-1 branch July 7, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants