Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specified modules to be compiled without optimization #233

Merged
merged 7 commits into from
Oct 3, 2022

Conversation

eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Oct 3, 2022

Purpose

This PR proposes a way to compile specified modules without optimization to be able to use optimization flags such as -ffast-math without altering the behavior for checking NaN behavior.

Expected time until merged

As long as necessary

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Please check that the modules are built in correct order and without optimization, both for real and complex.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner October 3, 2022 14:10
@eirikurj eirikurj requested review from marcomangano and anilyil and removed request for a team October 3, 2022 14:10
@eirikurj eirikurj mentioned this pull request Oct 3, 2022
12 tasks
@eirikurj eirikurj requested a review from sseraj October 3, 2022 14:14
@sseraj
Copy link
Collaborator

sseraj commented Oct 3, 2022

I had to make some changes to get the real build working. The complex build does not work though. I think we have to update src_cs/build/Makefile

@eirikurj
Copy link
Contributor Author

eirikurj commented Oct 3, 2022

Ah yes, let me address this.

@eirikurj
Copy link
Contributor Author

eirikurj commented Oct 3, 2022

@sseraj, pushed some fixes. I also updated the description with "testing" description, just to make sure its there.

Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this catches NaNs for my complex case

@sseraj sseraj merged commit 20a353e into mdolab:modernize-fortran Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants