Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding flag on complex build to support gcc 10 #245

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Adding flag on complex build to support gcc 10 #245

merged 1 commit into from
Nov 11, 2022

Conversation

eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Nov 11, 2022

Purpose

This PR adds the -fallow-argument-mismatch flag to the complex build if it detects GCC version 10 and newer. This is equivalent to what was done in #244.

Expected time until merged

Should be quick.

Type of change

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Test compiling adflow with GCC 10+ either locally or in a container using the complex build.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner November 11, 2022 12:20
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #245 (c2eaf28) into main (83a611d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   41.35%   41.35%           
=======================================
  Files          13       13           
  Lines        3794     3794           
=======================================
  Hits         1569     1569           
  Misses       2225     2225           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that the complex build also works now with GCC 10+

@ewu63 ewu63 merged commit ee39337 into main Nov 11, 2022
@ewu63 ewu63 deleted the fixComplex branch November 11, 2022 14:58
eirikurj added a commit to eirikurj/adflow that referenced this pull request Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants