Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed minor formatting issue #270

Merged
merged 1 commit into from
Mar 3, 2023
Merged

fixed minor formatting issue #270

merged 1 commit into from
Mar 3, 2023

Conversation

anilyil
Copy link
Contributor

@anilyil anilyil commented Mar 3, 2023

Purpose

Error check formatting string had a typo

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@anilyil anilyil requested a review from a team as a code owner March 3, 2023 02:45
sseraj
sseraj approved these changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@anilyil anilyil merged commit 829529d into mdolab:main Mar 3, 2023
@anilyil anilyil deleted the format_fix branch March 3, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sseraj sseraj sseraj approved these changes

@marcomangano marcomangano Awaiting requested review from marcomangano marcomangano is a code owner automatically assigned from mdolab/adflow_maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anilyil @sseraj