-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SST #301
Merged
Merged
SST #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el, and turbulence residuals equal to 0 in all other models except SA. See related issue !99.
…n -fcheck=all. GCC complained about passing a non-allocated allocatable as an argument.
…ty with includeHalo=true. However, we should be able to compute eddyVisc in the halo region using BCs, which is what is done right after.
…stency with the call to compute EddyViscosity. However, production terms contain a FD derivative so it should never be evaluated in halo cells.
… is still available, but we set the 2003 as default using a compilation flag SST_2003. This change was made because a lot of convergence issues were observed with the original one, and it seemed to be relaxed a bit with the 2003 version. It also seems to be the version most often implemented in other codes.
…g out the correctForK on simplePressure for performance reason.
…lence and flow residuals. As indicated in code comments, the turbulence residuals should be computed first so that K can be used later in the flow residual, for we need to correct rho and E.
Bugfix on turbulence models
… now we DO have halos for d2wall
Fix for NaN in ANK even in decoupled mode
d2wall before it was initialized
anilyil
requested review from
eirikurj and
anilyil
and removed request for
a team
September 6, 2023 13:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I took the
turbfix
branch, updated it to master and started working on SST.The biggest Problem with differentiating SST was the blending function
f1
as it had some mpi-communication inside. I managed to get rid of this communication by extendingd2wall
to both layers of halo cells.This is not production ready, but a bit of progress has been made. The following list explains what works and what doesn't in a random order:
forward partials seem to be correct
backwards partials seem to be correct apart from nodal forces
backwards_fast partials are all over the place
ANK/NK does work with ADPC, but early on DADI is more efficient
ANK/NK does not really work using FDPC, i suspect SST is highly non-linear and maybe the step is poorly chosen for this model. Not sure
Physicality check for SST-ANK probably needs adjustment as i sometimes encountered NaNs
Adjoint using forward routines does converge and aerodynamic derivatives seem to be correct, the geometric ones are not
Adjoint using backwards_fast routines does converge, but the derivatives are very wrong
There is probably a bug in the backwards routines for the
d2wall
extension I introducedGrid Convergence
I also run a grid-convergence for the 2D bump testcase here:
strain
for turbulence production instead ofvorticity
Solver Convergence
Convergence plot for a NACA0012 testcase:
modified
is the current state andbase
was the state beforeGradients
Relative tolerance of gradients (d Cl / d x) compared to CS with a stepsize of
1e-200
using the tutorial wing1e-40
is so different to1e-200
. I think it is because SST appears to be highly-nonlinearExpected time until merged
I dont know.
Type of change
Testing
I extended the basic tests such as
test_jacVecProdBWDFast.py
,test_jacVecProdFWD.py
,test_functionals.py
andtest_adjoint.jpy
. But as indicated above, most do not pass.Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable