Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Intel configs, removed outdated configs, and added graphviz for docs rendering #310

Merged
merged 6 commits into from
Aug 24, 2023

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Aug 23, 2023

Purpose

I updated the Intel config files so that they work with Intel MPI and HPE MPI (used on NAS). The config files check for the I_MPI_ROOT environment variable to determine if Intel MPI is being used.

In addition, I removed the following outdated config files:

  • config.LINUX_INTEL_SAFE.mk because -O2 is generally safe with ifort and we have been testing this for several years now
  • config.OSX_GFORTRAN.mk because this is untested, most likely broken, and we have the ARM Docker images now
  • The old_architectures folder because these files are 10+ years old and clutter the search results for the repo

Expected time until merged

1 week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

I tested on one of our Intel MPI images and on NAS with HPE MPI.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner August 23, 2023 13:48
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #310 (4ded19b) into main (e7ada3d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   41.98%   41.98%           
=======================================
  Files          13       13           
  Lines        4001     4001           
=======================================
  Hits         1680     1680           
  Misses       2321     2321           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

marcomangano
marcomangano previously approved these changes Aug 23, 2023
Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcomangano marcomangano changed the title Updated Intel configs and removed outdated configs Updated Intel configs, removed outdated configs, and added graphviz for docs rendering Aug 24, 2023
@lamkina lamkina merged commit 3effb6c into main Aug 24, 2023
16 checks passed
@sseraj sseraj deleted the intel-config branch August 24, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants