Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed travis to run on 2 procs #62

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Changed travis to run on 2 procs #62

merged 3 commits into from
Jun 25, 2020

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Jun 23, 2020

Purpose

I changed Travis to run tests using 2 processors, since that's what's available. Oversubscribing doesn't make sense and I don't think this reduces test coverage in any way.

@ewu63 ewu63 requested a review from a team as a code owner June 23, 2020 15:11
@ewu63
Copy link
Collaborator Author

ewu63 commented Jun 23, 2020

The reason py2 failed is because

  • default options have key in all lower case, but for tests 16-18 the updated options had key in mixed case, so the final options dictionary had both gridfile and gridFile entries
  • in py2 the dictionary order is different than py3, so by chance py3 took the gridFile option when py2 took the gridfile option

I will push a fix where all updated options also have their names in lower case. In the future, maybe we should implement a CaseInsenstiveDict or something for the options?

@ewu63 ewu63 requested a review from eirikurj June 24, 2020 12:40
Copy link
Contributor

@eirikurj eirikurj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The options dict should already be a CaseInsensitiveDict. In this specific case its just like you said, the order is different and one gets processed before the other, overwriting the previous set gridfile value.

Copy link
Contributor

@eirikurj eirikurj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The options dict should already be a CaseInsensitiveDict. In this specific case its just like you said, the order is different and one gets processed before the other, overwriting the previous set gridfile value.

@eirikurj eirikurj merged commit 5b9645b into master Jun 25, 2020
@eirikurj eirikurj deleted the test-change-nprocs branch June 25, 2020 20:55
marcomangano pushed a commit to marcomangano/adflow that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants