Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile #65

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Update Makefile #65

merged 2 commits into from
Jul 3, 2020

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Jul 3, 2020

Purpose

During complex build, the importTest.py file is copied from the f2py directory but still executed from the old location. This is fine if the $PYTHONPATH starts or ends with a colon, as it means the current folder is added to sys.path. The import test will fail if the colon is not there.

To fix this, I have moved the importTest into the build directory, where the .so files are actually built. That way, we are testing in the same folder and there will be no import issues.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Maintenance

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner July 3, 2020 16:27
@eirikurj eirikurj merged commit 97c752d into master Jul 3, 2020
@eirikurj eirikurj deleted the fix-build branch July 3, 2020 17:00
marcomangano pushed a commit to marcomangano/adflow that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants