Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label_line_ends and example #32

Merged
merged 9 commits into from
Jan 31, 2023
Merged

Add label_line_ends and example #32

merged 9 commits into from
Jan 31, 2023

Conversation

A-CGray
Copy link
Member

@A-CGray A-CGray commented Jan 30, 2023

Purpose

Adds a new helper function that makes it easier to automatically label the ends of lines.

line_end_labels

Expected time until merged

2 weeks

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner January 30, 2023 19:55
Copy link
Contributor

@eytanadler eytanadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll be a great addition! I've done it a few times manually so it'll be nice to have as a single function call. I have a few comments

niceplots/utils.py Outdated Show resolved Hide resolved
niceplots/utils.py Outdated Show resolved Hide resolved
niceplots/utils.py Show resolved Hide resolved
niceplots/utils.py Show resolved Hide resolved
Copy link
Contributor

@eytanadler eytanadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*chef's kiss*

@A-CGray A-CGray merged commit 96ac003 into main Jan 31, 2023
@A-CGray A-CGray deleted the lineEndLabels branch January 31, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants