Added Travis tests #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are now passing, after new Docker images from Docker Hub is used. |
eirikurj
approved these changes
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the examples as tests, which is at least better than nothing. Currently we just run each example (with one proc only, so not testing MPI), and verify that
cgns_utils infoandcgns_utils blockSizesgive the expected outputs. No checking of mesh quality or coordinates is done.Things are run in command line via subprocess, which is probably not great. Ideally we include the run script in the testing script, so we can test MPI also. We can do the same with
cgns_utilsand not have to parse the stdout to pick out integers. These integers are also hard-coded in the file, but could be split out into a reference file.The build fails now, due to this PR for cgns utilities not yet included in the Docker image. By tomorrow this should be updated and the test should succeed.