-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to use custom theme #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked this with the MDO Lab theme code to understand the changes. It makes a lot of sense to me, and I am fine with using this PR as a blueprint to update the other packages.
@marcomangano @sseraj, what I mean by I'm not sure about the imports is that, even more stuff can be imported:
Maybe it doesn't matter, and this PR as-is is more explicit. |
Oh yeah @nwu63 , importing the |
Yes agreed, and leaving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would adding html_theme
to the global config.py
cause problems in requirements.txt
? If not, I am inclined to adding it there and importing it.
Nope, it should be fine. Alright, I'll update the package to make that available for import here. |
So I ended up adding all the built-in sphinx extensions to config.py, I think that's relatively clean. The extra ones like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very clean, let's extend this to the other repos!
Purpose
We created a custom theme which is published on pyPI, to help make all the documentation sites consistent. This accomplishes several things
conf.py
can be set globally, and imported in each repo without having to change the setting for each repo, e.g. the copyright yearType of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
No need
Checklist
Put an
x
in the boxes that apply.flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted