Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating config files to use the more modern wrappers #51

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Conversation

eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Jul 15, 2021

Purpose

Updates the compilers wrappers used. Now the more modern fortran mpi compiler wrapper mpifort used instead of the mpif90, see here for GNU and similarly for Intel mpiifort, see here

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Tested on c7-intel-impi-latest and u20-gcc-ompi-latest

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner July 15, 2021 18:25
@eirikurj eirikurj requested a review from sseraj July 28, 2021 23:31
@sseraj sseraj merged commit 780fd7a into master Jul 29, 2021
@sseraj sseraj deleted the updateConf branch July 29, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants