Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tips for a Coarse Grid #53

Merged
merged 5 commits into from
Aug 23, 2021
Merged

Tips for a Coarse Grid #53

merged 5 commits into from
Aug 23, 2021

Conversation

akleb
Copy link
Contributor

@akleb akleb commented Aug 17, 2021

Purpose

Add some documentation for trouble shooting really coarse grids that are intended to be used as a starting point for adaptive meshing.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@akleb akleb requested a review from a team as a code owner August 17, 2021 18:54
@akleb
Copy link
Contributor Author

akleb commented Aug 17, 2021

Information from mdolab/MACH-Aero#57

@akleb akleb mentioned this pull request Aug 17, 2021
12 tasks
@sseraj sseraj self-requested a review August 17, 2021 19:13
Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor comments

doc/adapt.rst Outdated Show resolved Hide resolved
doc/adapt.rst Outdated Show resolved Hide resolved
Below is an example of a mesh that pyHyp created with obvious negative volumes.
This is a bit of a ridiculous example, but someone actually managed to get a grid that looked like this on accident.

.. image:: images/Figure_CoarseWarp.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images should be smaller. Maybe something like :width: 400

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, could you also add :align: center?

doc/adapt.rst Outdated Show resolved Hide resolved
doc/adapt.rst Outdated Show resolved Hide resolved
doc/adapt.rst Outdated Show resolved Hide resolved
@marcomangano
Copy link
Contributor

This PR looks good to go, @joanibal @SichengHe can you review it and merge if ready?

@joanibal joanibal merged commit 6017054 into mdolab:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants