-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tips for a Coarse Grid #53
Conversation
Information from mdolab/MACH-Aero#57 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some minor comments
Below is an example of a mesh that pyHyp created with obvious negative volumes. | ||
This is a bit of a ridiculous example, but someone actually managed to get a grid that looked like this on accident. | ||
|
||
.. image:: images/Figure_CoarseWarp.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The images should be smaller. Maybe something like :width: 400
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing, could you also add :align: center
?
This PR looks good to go, @joanibal @SichengHe can you review it and merge if ready? |
Purpose
Add some documentation for trouble shooting really coarse grids that are intended to be used as a starting point for adaptive meshing.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
x
in the boxes that apply.flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted