-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved simpleOCart and updated imports #61
Conversation
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 76.30% 79.95% +3.64%
==========================================
Files 3 4 +1
Lines 363 414 +51
==========================================
+ Hits 277 331 +54
+ Misses 86 83 -3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me. Curious as to why the cgnsutilities call needs to be done in python rather than the CLI? Is this just for uniformity?
It didn't need to be, but it helps keep the dependencies traceable if we actually import the module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of @eirikurj
Purpose
I made several changes mainly related to the imports:
Once this is merged, I will remove simpleOCart from cgnsUtilities and update the tutorials that use simpleOCart.
Expected time until merged
One week
Type of change
Testing
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted