Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved simpleOCart and updated imports #61

Merged
merged 10 commits into from
May 9, 2022
Merged

Moved simpleOCart and updated imports #61

merged 10 commits into from
May 9, 2022

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Apr 8, 2022

Purpose

I made several changes mainly related to the imports:

  • Moved simpleOCart from cgnsUtilities
  • Updated functions to use cgnsUtilities from Python instead of calling the CLI
  • Updated requirements in setup.py
  • Fixed a bug in the tests where the tests passed even though cgnsdiff did not run properly (such as when files are missing)
  • Added a test for simpleOCart

Once this is merged, I will remove simpleOCart from cgnsUtilities and update the tutorials that use simpleOCart.

Expected time until merged

One week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner April 8, 2022 21:05
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #61 (94e2614) into main (60382f8) will increase coverage by 3.64%.
The diff coverage is 91.54%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   76.30%   79.95%   +3.64%     
==========================================
  Files           3        4       +1     
  Lines         363      414      +51     
==========================================
+ Hits          277      331      +54     
+ Misses         86       83       -3     
Impacted Files Coverage Δ
pyhyp/pyHyp.py 76.07% <91.30%> (+2.38%) ⬆️
pyhyp/utils.py 91.66% <91.66%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sseraj sseraj requested review from gawng and removed request for SichengHe April 18, 2022 14:24
Copy link
Contributor

@gawng gawng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. Curious as to why the cgnsutilities call needs to be done in python rather than the CLI? Is this just for uniformity?

@sseraj
Copy link
Collaborator Author

sseraj commented Apr 22, 2022

Looks pretty good to me. Curious as to why the cgnsutilities call needs to be done in python rather than the CLI? Is this just for uniformity?

It didn't need to be, but it helps keep the dependencies traceable if we actually import the module.

Copy link
Collaborator

@ewu63 ewu63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of @eirikurj

@ewu63 ewu63 merged commit e6780ec into main May 9, 2022
@ewu63 ewu63 deleted the update-imports branch May 9, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants