-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Intel config file to work with HPE MPI #76
Conversation
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 79.48% 79.48%
=======================================
Files 4 4
Lines 424 424
=======================================
Hits 337 337
Misses 87 87 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff
@lamkina We need maintainers privileges to merge |
* renamed Intel config file * renamed gfortran config file * updated azure script * added MPI if check in Intel config * minor cleanup * updated docs * fixed Intel env var
Purpose
I updated the Intel config file so that it works with Intel MPI and HPE MPI (used on NAS). The config file checks for the
I_MPI_ROOT
environment variable to determine if Intel MPI is being used. I also updated the config file names and fixed the deprecated-nofor_main
flag.Expected time until merged
1 week
Type of change
Testing
I tested on our Intel MPI images and on NAS with HPE MPI.
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable