Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Intel config file to work with HPE MPI #76

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Aug 23, 2023

Purpose

I updated the Intel config file so that it works with Intel MPI and HPE MPI (used on NAS). The config file checks for the I_MPI_ROOT environment variable to determine if Intel MPI is being used. I also updated the config file names and fixed the deprecated -nofor_main flag.

Expected time until merged

1 week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

I tested on our Intel MPI images and on NAS with HPE MPI.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner August 23, 2023 13:18
@sseraj sseraj requested review from lamkina and gawng August 23, 2023 13:18
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #76 (a791d8b) into main (c115596) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   79.48%   79.48%           
=======================================
  Files           4        4           
  Lines         424      424           
=======================================
  Hits          337      337           
  Misses         87       87           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

marcomangano
marcomangano previously approved these changes Aug 23, 2023
Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gawng gawng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@marcomangano
Copy link
Contributor

@lamkina We need maintainers privileges to merge

@lamkina lamkina merged commit 1bc1854 into main Aug 30, 2023
11 checks passed
@sseraj sseraj deleted the intel-config branch August 30, 2023 15:36
DavidAnderegg pushed a commit to anilyil/pyhyp that referenced this pull request Sep 3, 2024
* renamed Intel config file

* renamed gfortran config file

* updated azure script

* added MPI if check in Intel config

* minor cleanup

* updated docs

* fixed Intel env var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants