-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docs package requirements to setup.py #290
Conversation
Codecov Report
@@ Coverage Diff @@
## main #290 +/- ##
=======================================
Coverage 84.16% 84.16%
=======================================
Files 22 22
Lines 3315 3315
=======================================
Hits 2790 2790
Misses 525 525
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also prune requirements.txt (here and in other repos)? numpydoc and sphinxcontrib-bibtex are both already required by sphinx_mdolab_theme.
Yes that'd be a good idea. I started adding dependencies to the mdolab theme but haven't gotten around to pruning the repos. |
I think we should also bump the patch version here. |
Purpose
As per title, now if the user wants to build the documentation locally, they can set all the dependencies using
pip install .[docs]
Expected time until merged
as soon as the tests pass?
Type of change
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted