Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run nsga2 single-objective case on Windows #354

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Aug 28, 2023

Purpose

Based on the comments from @marcomangano in #351, I got rid of the platform check so that we are running the single-objective test on all platforms, and disabling the multi-objective test.

Expected time until merged

No rush.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner August 28, 2023 23:49
@ewu63 ewu63 requested review from lamkina and sseraj August 28, 2023 23:49
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #354 (9a98f96) into main (01dece2) will decrease coverage by 11.92%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #354       +/-   ##
===========================================
- Coverage   84.42%   72.51%   -11.92%     
===========================================
  Files          22       22               
  Lines        3307     3307               
===========================================
- Hits         2792     2398      -394     
- Misses        515      909      +394     

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@marcomangano marcomangano merged commit ccc40ca into mdolab:main Aug 29, 2023
11 of 12 checks passed
@ewu63 ewu63 deleted the update-nsga2-test-skip branch August 29, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants