Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blade elements and buckling interface #4

Merged
merged 5 commits into from
Oct 14, 2020

Conversation

eirikurj
Copy link

Purpose

This PR addresses two things:

  • adds bladeFSDT class
  • adds KSBuckling interface

Originally developed by Tim (partially integrated by Ali/Nick). This PR is to clean up and splits into specific commits.

Before merging this please merge PR #3 first

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • New feature (non-breaking change which adds functionality)

Testing

Tests in pytacs repo can be run to test some of these additions. More tests should be added locally.

@eirikurj eirikurj requested a review from a team as a code owner October 14, 2020 16:44
@A-CGray
Copy link
Member

A-CGray commented Oct 14, 2020

Before I approve this @eirikurj did you run the test case in pytacs that uses the bladeFSDT elements?
https://github.com/mdolab/pytacs/blob/master/tests/reg_tests/test_wing.py

@eirikurj
Copy link
Author

Yes, I did update the tests and added a new example.
There is a pending PR here, https://github.com/mdolab/pytacs/pull/27

@A-CGray
Copy link
Member

A-CGray commented Oct 14, 2020

Oh perfect, nice one!

@A-CGray A-CGray merged commit 4b7c073 into mdolab:master Oct 14, 2020
@eirikurj eirikurj deleted the addBladeElements branch October 14, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants