Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Unicode half blocks #4

Merged
merged 3 commits into from
Dec 29, 2017
Merged

Use Unicode half blocks #4

merged 3 commits into from
Dec 29, 2017

Conversation

viric
Copy link
Contributor

@viric viric commented Dec 16, 2017

Here is a proposal implementation. It makes the config more complicated though.

viric and others added 3 commits December 16, 2017 15:50
- Half blocks allow for more characters/data in the qr code
with less sapce
- Also updated to RSC's qr code library now that it's fixed
@mdp
Copy link
Owner

mdp commented Dec 19, 2017

This looks like a great idea. I made some changes so it won't break the existing API. Also, what do you think about trying to use the quadrant block elements (U+2596 to U+259F, plus top and bottom half and full block)? You should be able to get even more compression this way.

@viric
Copy link
Contributor Author

viric commented Dec 20, 2017 via email

@mdp
Copy link
Owner

mdp commented Dec 21, 2017

Yeah, I played with it, and the issue I ran into was that quadrants "stretch" out the QR code vertically, so it's no longer square. I'll merge your half block changes later today and update the README.

Thanks for this, it's a really useful addition.

@mdp mdp merged commit 31b8311 into mdp:master Dec 29, 2017
@mdp
Copy link
Owner

mdp commented Dec 29, 2017

Merged and updated the docs. Thanks for adding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants