Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL2 update and fixes #94

Merged
merged 4 commits into from
Mar 31, 2013
Merged

Conversation

CyberShadow
Copy link
Contributor

An API update, a fix in a macro, and some whitespace trimmings.

Did the API update with these. Not sure how it's supposed to be done or if there's an easier way.

@CyberShadow
Copy link
Contributor Author

Oh, almost forgot. Here's the SDL2.dll I built and used for testing:
http://dump.thecybershadow.net/8736c03296acf915e31f0f372c971437/SDL2.dll
(SDL2 hg 177d1dc3dba6, release configuration)

@CyberShadow
Copy link
Contributor Author

Good news: The SDL 2 ABI has been frozen!

Also, I noticed there were some SDL_REVISION constants. Updated those + one more recent API change.

@mdparker
Copy link
Owner

Sorry for the delay. I've been afk for a couple of days. Ideally, the baseline for the binding should be the source snapshot they release at http://www.libsdl.org/hg.php. I got off track a while back with a pull request that updated to the latest mercurial head. That caused a bit of confusion until a new snapshot was released and I could stabilize on that. So I think what I'll do is keep this open, then when the next snapshot is released I'll merge it in before catching up.

@CyberShadow
Copy link
Contributor Author

Ah, OK! In theory this pull should be good to go whenever that happens, considering the ABI freeze.

In that case, it might make sense to update the SDL2.dll download so it's in sync with Derelict 3 master.

@mdparker
Copy link
Owner

Unfortunately, I can't do anything about the DLL. Github disabled downloads not that long ago. I can't even delete it.

@CyberShadow
Copy link
Contributor Author

Why not change the link, then?

@mdparker
Copy link
Owner

Ah, in the readme. Because I forgot all about it. Thanks!

@mdparker
Copy link
Owner

The snapshot was recently updated. So I'll go ahead and merge this. Then I'll look into what else needs to be done to get current.

mdparker added a commit that referenced this pull request Mar 31, 2013
@mdparker mdparker merged commit cba4b77 into mdparker:master Mar 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants