Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: arbitrum eips diffs #60

Closed
wants to merge 10 commits into from
Closed

feat: arbitrum eips diffs #60

wants to merge 10 commits into from

Conversation

leovct
Copy link
Contributor

@leovct leovct commented Feb 2, 2024

Related to #37.
Requires #59 to be merged (and to rebase this PR).

Add Arbitrum EIPs diffs. Just like Optimism diffs (#53), it adds diffs for EIP-1599 and EIP-4399 (PREVRANDAO).
@mds1 Not sure about EIP-4895 (withdrawals lists)?

Also fix a url formatting issue.

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evm-diff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 11:04am

@leovct leovct changed the title feat: arbitrum eips feat: arbitrum eips diffs Feb 2, 2024
@mds1
Copy link
Owner

mds1 commented Feb 2, 2024

Hey @gzeoneth, could you help us with some Arbitrum EIP information? Context is listing which mainnet EIPs are implemented, and what parameter differences there may be from mainnet. We're only listing execution related EIPs, no consensus, networking, etc. EIPs.

For example, here's what it looks like for Optimism‚the same EIPs are implemented, but with a few differences explained in the "Notes" section of each row: https://www.evmdiff.com/diff?base=1&target=10#eips

Hoping to get something similar for Arbitrum. I assume all EIPs are implemented, with the following exceptions:

  • No EIP-1559: A similar approach is used. Are there parameters we should use reference here? Any references you might have showing how it's equivalent would also be great.
  • EIP-4399: Just returns the constant 1
  • EIP-4895: Does arbitrum have an empty withdrawal list similar to Optimism?

Thanks!

@leovct leovct mentioned this pull request Feb 5, 2024
@gzeoneth
Copy link

gzeoneth commented Feb 5, 2024

Hey @gzeoneth, could you help us with some Arbitrum EIP information? Context is listing which mainnet EIPs are implemented, and what parameter differences there may be from mainnet. We're only listing execution related EIPs, no consensus, networking, etc. EIPs.

For example, here's what it looks like for Optimism‚the same EIPs are implemented, but with a few differences explained in the "Notes" section of each row: https://www.evmdiff.com/diff?base=1&target=10#eips

Hoping to get something similar for Arbitrum. I assume all EIPs are implemented, with the following exceptions:

  • No EIP-1559: A similar approach is used. Are there parameters we should use reference here? Any references you might have showing how it's equivalent would also be great.
  • EIP-4399: Just returns the constant 1
  • EIP-4895: Does arbitrum have an empty withdrawal list similar to Optimism?

Thanks!

  • EIP-1559: partially implemented with the following exception
    • target a gas per second ("speed limit") instead of block gas limit to account for the variable block time in Arbitrum
    • priority fee is not collected by the network even when nonzero value is specified
  • EIP-4399: Always returns 1
  • EIP-4895: Arbitrum currently do not generate block with withdrawalsRoot

Let me also circulate to my team to see if anything is missing

@mds1
Copy link
Owner

mds1 commented Mar 3, 2024

Let me also circulate to my team to see if anything is missing

Hey @gzeoneth just following up here to see if there was anything missing here?

@gzeoneth
Copy link

gzeoneth commented Mar 5, 2024

Let me also circulate to my team to see if anything is missing

Hey @gzeoneth just following up here to see if there was anything missing here?

LGTM tho fyi ArbOS 20 would be shipped around 10 days from now

@leovct leovct closed this Apr 29, 2024
@leovct leovct deleted the feat/arbitrum-eips branch April 29, 2024 17:06
@mds1 mds1 mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants