This repository has been archived by the owner on Apr 11, 2019. It is now read-only.
[MCC-128844] New logging in ZipkinTracerModule #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,8 +25,9 @@ public void Init(HttpApplication context) | |||
| var zipkinConfig = new ZipkinConfig(); | |||
|
|
|||
| var traceProvider = new TraceProvider(new System.Web.HttpContextWrapper(HttpContext.Current), zipkinConfig.DontSampleListCsv, zipkinConfig.ZipkinSampleRate); | |||
| var logger = new MDLogger(LogManager.GetLogger("ZipkinHttpModule"), traceProvider, new AssemblyLoader()); | |||
There was a problem hiding this comment.
We can work on getting this constructor piece better in the HttpModule in the refactor story.
There was a problem hiding this comment.
Minor feedback, it might be better using LogManager.GetLogger(type).
And I published Medidata.MDLogging version 0.0.3.0, please update the library!
|
@kenyamat |
| @@ -24,8 +25,9 @@ public void Init(HttpApplication context) | |||
| var zipkinConfig = new ZipkinConfig(); | |||
|
|
|||
| var traceProvider = new TraceProvider(new System.Web.HttpContextWrapper(HttpContext.Current), zipkinConfig.DontSampleListCsv, zipkinConfig.ZipkinSampleRate); | |||
| var logger = new MDLogger(LogManager.GetLogger(this.GetType().Name), traceProvider, new AssemblyLoader()); | |||
There was a problem hiding this comment.
You can pass Type instance using this.GetType() into GetLogger. Sorry for minor feedback.
|
@kenyamat |
|
Thanks! |
kenyamat
added a commit
that referenced
this pull request
Oct 1, 2014
[MCC-128844] New logging in ZipkinTracerModule
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BPONTES @kenyamat