This repository has been archived by the owner on Apr 11, 2019. It is now read-only.
[MCC-186539] .Net zipkin reporting calling service correctly #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,6 +83,7 @@ | |||
| <ItemGroup> | |||
| <Compile Include="Properties\AssemblyInfo.cs" /> | |||
| <Compile Include="SpanTracerTests.cs" /> | |||
| <Compile Include="ZipkinConfigTests.cs" /> | |||
| @@ -32,12 +29,25 @@ public string SpanProcessorBatchSize | |||
|
|
|||
| public string DontSampleListCsv | |||
| { | |||
| get { return ConfigurationManager.AppSettings["mAuthWhitelist"];} | |||
| get { return ConfigurationManager.AppSettings["uriBlacklist"];} // TODO: refactor this later if it is being used | |||
|
@bvillanueva-mdsol LGTM, could you bump version up for nuget and add your name into contributors? |
kenyamat
added a commit
that referenced
this pull request
Sep 29, 2015
[MCC-186539] .Net zipkin reporting calling service correctly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kenyamat @BPONTES @jcarres-mdsol
This PR will correct the service name logged when doing a client trace.
Client trace will accept a URI as parameter, and gets the hostname as service name when logging it to zipkin.
Added and adjusted some unit tests too.
Please review and merge if ok.
Thanks,
Brent