Remove trailing space from generated yaml warning message #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, not sure about the CI failure, seems not related though 😕 https://travis-ci.org/mdsol/dice_bag/jobs/410648898
|
|
I see.. we're removing failing ruby 1.9.3 from the CI in https://github.com/mdsol/dice_bag/pull/83/files#diff-354f30a63fb0907d4ad57269548329e3L3 |
|
since the code has changed, even a TEENY update may be needed.
|
piao-mdsol
force-pushed
the
feature/remove-trailing-space-from-yaml-warning-message
branch
from
8ef6b80
to
9fa4ef2
Compare
|
@mdsol/team-10 Rebased and now CI passed, please 🙏 |
|
wasn't this the PR where you'd update the changelog and do a TEENY bump? |
|
@jfeltesse-mdsol sorry I got completely lost between switching branches 😓 🙇 🤦♂️ |
jfeltesse-mdsol
approved these changes
Aug 2, 2018
jfeltesse-mdsol
deleted the
feature/remove-trailing-space-from-yaml-warning-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
Noticed a trailing space 👾 is left in the generated yaml warning message. 👇
So take the chance to chop it ✂️ 🙂
FYI @mdsol/team-10