This repository has been archived by the owner on Jan 18, 2023. It is now read-only.
Update ice cookbook #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shortdudey123
commented
Jun 20, 2015
shortdudey123
commented
- Add support for Add travis job to run rubocop/foodcritic on PR's #29
- Allow nginx to be optional
- Update to be compatible with Tomcat 7
- Add testing on CentOS 7.1
Starting with Tomcat v7, the version number is no longer included in the service name
This allows the cookbook to be used to install ice with tomcat but still allow other nginx configs in a wrapper cookbook.
|
Thanks @shortdudey123! @rayrod2030 do you have time to take a look at this? |
|
Great pull request. I'll try to review it in the next couple of days. On Mon, Jun 22, 2015 at 6:01 AM, Harry Wilkinson notifications@github.com
|
|
@rayrod2030 any update from your side? |
|
Sorry for the delay. These changes look great. Merging! |
|
No problem and thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.