This repository has been archived by the owner on Apr 10, 2024. It is now read-only.
Port Dice Bag CI tasks #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds new material on the need for existing rake tasks, the relationship with Dice Bag and on running locally.
|
|
||
| ```ruby | ||
| group :development, :test do | ||
| gem 'kender', :git => 'git@github.com:mdsol/kender.git' |
There was a problem hiding this comment.
We can make shamus and brakeman direct dependencies of this gem so the user of Kender does not need to explicitily write them.
It may be a problem if/when we opensource this, because Shamus is private but Shamus should also be opensourced anyway ... :P
There was a problem hiding this comment.
Yes, agreed but I want this PR to be just a straight port of what was in Dice Bag. If/when this is made open source we can pull out the Medidata-specific parts into a gem that extends the generic behavior here (or something similar/better).
|
Comments addressed, ready for review/merge. |
|
Love it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from renaming, the code here is unchanged from that currently in mdsol/dice_bag with the configuration infrastructure/tasks removed. The README contains additions and I would appreciate a more in-depth review there.
For any of @jcarres-mdsol, @mszenher or @chad-medi to review. If we can get this merged before this week's reveal that would be great, thanks!