-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only install enum34 for python2.7 as it breaks for python36 #84
Only install enum34 for python2.7 as it breaks for python36 #84
Conversation
setup.py
Outdated
@@ -26,6 +28,13 @@ | |||
author = re.search("__author__ = '([^']+)'", rwsinit).group(1) | |||
version = re.search("__version__ = '([^']+)'", rwsinit).group(1) | |||
|
|||
INSTALL_REQUIRES = ['requests', 'lxml', 'httpretty', 'six', 'click', 'faker'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Could we use enum34; python_version < '3.4'
?
It saves declaring another var?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great suggestion, I didn't know it was possible
edd7e88
to
290e97f
Compare
Thanks for this, can we bump the minor version by one for this as well? Small issue with the CI, which I need to resolve before I can approve and move on. |
alright, version bumped to 1.2.2 :) |
Thanks, looks good. Just trying to sort out the travis-ci issue which is blocking merges. |
Going to close and reopen the PR to prompt Travis CI to catch up |
Ok, the interop of httpretty and python3 and later causes issues with the unittests (something to do with an unclosed socket). I've made a small branch across at https://github.com/mdsol/rwslib/tree/feature/drop_python_33 to address. Can you update the |
Thanks for this. One final change; can you remove 3.3 from the |
Also, add your handle to the |
sure no problem :) its done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hi, We recently switched to pyton3.6 and the fact that enum34 gets installed automatically by rwslib is breaking a few things.
https://bitbucket.org/stoneleaf/enum34/issues/19/enum34-isnt-compatible-with-python-36
I applied a fix that is similar to a PR on grpc
grpc/grpc#10227