Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only install enum34 for python2.7 as it breaks for python36 #84

Merged
merged 5 commits into from
Jun 14, 2018

Conversation

bagerard
Copy link
Contributor

@bagerard bagerard commented May 18, 2018

Hi, We recently switched to pyton3.6 and the fact that enum34 gets installed automatically by rwslib is breaking a few things.
https://bitbucket.org/stoneleaf/enum34/issues/19/enum34-isnt-compatible-with-python-36

I applied a fix that is similar to a PR on grpc
grpc/grpc#10227

setup.py Outdated
@@ -26,6 +28,13 @@
author = re.search("__author__ = '([^']+)'", rwsinit).group(1)
version = re.search("__version__ = '([^']+)'", rwsinit).group(1)

INSTALL_REQUIRES = ['requests', 'lxml', 'httpretty', 'six', 'click', 'faker']
Copy link
Member

@glow-mdsol glow-mdsol May 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Could we use enum34; python_version < '3.4' ?

It saves declaring another var?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great suggestion, I didn't know it was possible

@bagerard bagerard force-pushed the enum34_not_compatible_py36 branch from edd7e88 to 290e97f Compare May 30, 2018 10:46
@glow-mdsol
Copy link
Member

glow-mdsol commented Jun 4, 2018

Thanks for this, can we bump the minor version by one for this as well? Small issue with the CI, which I need to resolve before I can approve and move on.

@bagerard
Copy link
Contributor Author

bagerard commented Jun 5, 2018

alright, version bumped to 1.2.2 :)

@glow-mdsol
Copy link
Member

Thanks, looks good. Just trying to sort out the travis-ci issue which is blocking merges.

@glow-mdsol
Copy link
Member

Going to close and reopen the PR to prompt Travis CI to catch up

@glow-mdsol glow-mdsol closed this Jun 10, 2018
@glow-mdsol glow-mdsol reopened this Jun 10, 2018
@glow-mdsol glow-mdsol closed this Jun 11, 2018
@glow-mdsol glow-mdsol reopened this Jun 11, 2018
@glow-mdsol
Copy link
Member

Ok, the interop of httpretty and python3 and later causes issues with the unittests (something to do with an unclosed socket). I've made a small branch across at https://github.com/mdsol/rwslib/tree/feature/drop_python_33 to address. Can you update the test_rwscmd.py per that branch and then push the commits. It should then allow the CI to complete successfully.

@glow-mdsol
Copy link
Member

Thanks for this. One final change; can you remove 3.3 from the .travis.yml. The setup can't deal with the versioned requirement, and TBH it's such an old release I think we can skip it

@glow-mdsol
Copy link
Member

Also, add your handle to the AUTHORS.rst for the credit where due

@bagerard
Copy link
Contributor Author

sure no problem :) its done

Copy link
Member

@glow-mdsol glow-mdsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@glow-mdsol glow-mdsol merged commit a969170 into mdsol:develop Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants