Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MDX v2 #204

Closed
johno opened this issue May 20, 2020 · 5 comments · Fixed by #284
Closed

Support for MDX v2 #204

johno opened this issue May 20, 2020 · 5 comments · Fixed by #284
Labels
📦 area/deps This affects dependencies 🧑 semver/major This is a change 🦋 type/enhancement This is great to have 🙆 yes/confirmed This is confirmed and ready to be worked on
Milestone

Comments

@johno
Copy link
Member

johno commented May 20, 2020

Thanks for the amazing package @JounQin!

For v2 it looks like we'll need to change a few things with this package, it's currently silently failing when run in the next branch of mdx-js/mdx. Will you have any time in the next month or so to ensure compatibility?

~/c/mdx next ⇡
❯ yarn lint
yarn run v1.17.3
$ eslint . --cache --ext js,jsx,md,mdx -f friendly

Oops! Something went wrong! :(

ESLint: 7.0.0


error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

~/c/mdx next 6s
@johno johno added 🐛 type/bug This is a problem 🙆 yes/confirmed This is confirmed and ready to be worked on labels May 20, 2020
@JounQin
Copy link
Member

JounQin commented May 20, 2020

Sure, I'll take a look ASAP.

@JounQin
Copy link
Member

JounQin commented May 24, 2020

@johno 80686eb#commitcomment-38853669
This commit has not been published yet, that's why ESLint breaks.

@JounQin
Copy link
Member

JounQin commented May 25, 2020

@johno @wooorm So would like publish a new version?

@wooorm
Copy link
Member

wooorm commented May 26, 2020

Done

@JounQin JounQin closed this as completed Aug 5, 2020
@JounQin JounQin reopened this Mar 26, 2021
@JounQin JounQin added 📦 area/deps This affects dependencies 🦋 type/enhancement This is great to have 🧑 semver/major This is a change and removed 🐛 type/bug This is a problem labels Mar 26, 2021
@JounQin JounQin added this to the 2.0 milestone Mar 26, 2021
@JounQin JounQin linked a pull request Mar 26, 2021 that will close this issue
@JounQin
Copy link
Member

JounQin commented Mar 27, 2022

# yarn 1
yarn add https://pkg.csb.dev/mdx-js/eslint-mdx/commit/abdc9db9/eslint-mdx https://pkg.csb.dev/mdx-js/eslint-mdx/commit/abdc9db9/eslint-plugin-mdx
# yarn 2, 3
yarn add eslint-mdx@https://pkg.csb.dev/mdx-js/eslint-mdx/commit/abdc9db9/eslint-mdx/_pkg.tgz eslint-plugin-mdx@https://pkg.csb.dev/mdx-js/eslint-mdx/commit/abdc9db9/eslint-plugin-mdx/_pkg.tgz
# npm
npm i https://pkg.csb.dev/mdx-js/eslint-mdx/commit/abdc9db9/eslint-mdx https://pkg.csb.dev/mdx-js/eslint-mdx/commit/abdc9db9/eslint-plugin-mdx

Please help us to test the fresh new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies 🧑 semver/major This is a change 🦋 type/enhancement This is great to have 🙆 yes/confirmed This is confirmed and ready to be worked on
Development

Successfully merging a pull request may close this issue.

3 participants