Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing unist-util-visit and vfile deps #405

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jun 28, 2022

close #404

@JounQin JounQin added 🐛 type/bug This is a problem 📦 area/deps This affects dependencies 👶 semver/patch This is a backwards-compatible fix labels Jun 28, 2022
@JounQin JounQin requested a review from wooorm June 28, 2022 02:14
@JounQin JounQin self-assigned this Jun 28, 2022
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #405 (98013f6) into master (4283717) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #405   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          195       195           
  Branches        40        40           
=========================================
  Hits           195       195           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4283717...98013f6. Read the comment docs.

@JounQin JounQin merged commit 6b4fea7 into master Jun 28, 2022
@JounQin JounQin deleted the fix/deps branch June 28, 2022 02:40
@JounQin
Copy link
Member Author

JounQin commented Jun 28, 2022

Ready for a new release @wooorm

Both v1 and v2, thanks!

@wooorm
Copy link
Member

wooorm commented Jun 29, 2022

Can you land it on v1 too, so that I can release it?

@JounQin
Copy link
Member Author

JounQin commented Jun 29, 2022

Can you land it on v1 too, so that I can release it?

v1 does not need this

@wooorm
Copy link
Member

wooorm commented Jun 29, 2022

Oh you meant: release both.
I read it as: release this on both! 👍

So you have a recommendation for how to release the v1 branch?

@wooorm
Copy link
Member

wooorm commented Jun 29, 2022

I released v2

@JounQin
Copy link
Member Author

JounQin commented Jun 29, 2022

Oh you meant: release both. I read it as: release this on both! 👍

So you have a recommendation for how to release the v1 branch?

@wooorm

There is a release-v1 branch, you release v1 as usual.

@wooorm
Copy link
Member

wooorm commented Jun 29, 2022

That would likely create a latest release on npm?
But I need to release under a different npm tag.
Similar to the release-next script.
Or does yarn release do that magically?

@JounQin
Copy link
Member Author

JounQin commented Jun 30, 2022

That would likely create a latest release on npm?
But I need to release under a different npm tag.
Similar to the release-next script.
Or does yarn release do that magically?

Oh, I forget about that, maybe you update the dist tag in release-v1 branch?

@wooorm
Copy link
Member

wooorm commented Jul 8, 2022

It worked! https://github.com/mdx-js/eslint-mdx/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Development

Successfully merging this pull request may close these issues.

Parsing error: visit is not a function
3 participants