Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove autolink support ✅ #1049

Closed
johno opened this issue May 1, 2020 · 2 comments
Closed

RFC: Remove autolink support ✅ #1049

johno opened this issue May 1, 2020 · 2 comments
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change 💬 type/discussion This is a request for comments 🦋 type/enhancement This is great to have 💎 v2 Issues related to v2
Milestone

Comments

@johno
Copy link
Member

johno commented May 1, 2020

Autolinks are a feature in Markdown that allow you to wrap a url in angle brackets: <https://mdxjs.com>. Currently, in v1, we support them but with the parser changes in #1039 they've been dropped.

This comes at a cost of breaking perfect interoperability with Markdown, but perhaps it makes sense because it makes < a clearer boundary for JSX syntax, which may be more clear to users. It might also be more confusing.

This issue is for discussing the potential implications of removing autolink syntax.

@johno johno added 🦋 type/enhancement This is great to have 💬 type/discussion This is a request for comments 💎 v2 Issues related to v2 🗄 area/interface This affects the public interface 🧑 semver/major This is a change labels May 1, 2020
@johno johno mentioned this issue May 1, 2020
25 tasks
@wooorm
Copy link
Member

wooorm commented May 1, 2020

TL;DR (from here) on why I think they’re a bad idea to support:

The reason for this change is because whether something is an element (whether HTML or JSX) or an autolink is ambiguous (Markdown normally treats <svg:rect>, <xml:lang/>, or <svg:circle{...props}> as links).

@wooorm
Copy link
Member

wooorm commented May 1, 2020

Extra--while this is a bit far away for most folks except for John and me who have tried the new parsing out--we now have error messages that point to exactly where a typo/problem is, with a reason, and what was expected. That greatly improves developer experience. If we relax around things that might be a link, errors will start slipping through unnoticed.

@johno johno changed the title RFC: Remove autolink support RFC: Remove autolink support ✅ May 20, 2020
@johno johno added the 🙆 yes/confirmed This is confirmed and ready to be worked on label May 20, 2020
@johno johno closed this as completed May 20, 2020
@johno johno added this to the v2 milestone Jul 22, 2020
@wooorm wooorm added ⛵️ status/released and removed 🙆 yes/confirmed This is confirmed and ready to be worked on labels Jul 23, 2020
@wooorm wooorm added the 💪 phase/solved Post is done label Dec 24, 2021
MTRNord added a commit to MTRNord/matrix.org that referenced this issue Aug 24, 2022
shubham-padia added a commit to shubham-padia/zulip that referenced this issue Jun 17, 2024
mdxjs does not allow autolinks.
See mdx-js/mdx#1049.
We also added a linter check for the same.
Preparatory commit for zulip#30451.
timabbott pushed a commit to zulip/zulip that referenced this issue Jun 17, 2024
mdxjs does not allow autolinks.
See mdx-js/mdx#1049.
We also added a linter check for the same.
Preparatory commit for #30451.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change 💬 type/discussion This is a request for comments 🦋 type/enhancement This is great to have 💎 v2 Issues related to v2
Development

No branches or pull requests

2 participants